-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test coverage for TreeView component #18072
Test coverage for TreeView component #18072
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18072 +/- ##
==========================================
+ Coverage 82.87% 83.22% +0.35%
==========================================
Files 404 404
Lines 14338 14338
Branches 4591 4641 +50
==========================================
+ Hits 11882 11933 +51
+ Misses 2296 2243 -53
- Partials 160 162 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Hey @soumyaraju Thanks for opening that! |
Thanks @guidari for looking into this PR, i added few more tests to cover the uncovered lines, thus increased coverage, Please review it. TIA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thnaks @soumyaraju
LGTM 🚀
Thanks for the approval, @guidari can you help me merging this PR? TIA |
f2ba3fd
Closes #17502
Added tests for TreeView component