Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage for TreeView component #18072

Merged
merged 13 commits into from
Nov 25, 2024

Conversation

soumyaraju
Copy link
Contributor

@soumyaraju soumyaraju commented Nov 14, 2024

Closes #17502

Added tests for TreeView component

@soumyaraju soumyaraju requested a review from a team as a code owner November 14, 2024 13:02
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit a71ca43
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/674474ca00d95c0008720e8b
😎 Deploy Preview https://deploy-preview-18072--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a71ca43
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/674474ca24387b0008333492
😎 Deploy Preview https://deploy-preview-18072--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a71ca43
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/674474ca9d594700088ef7cf
😎 Deploy Preview https://deploy-preview-18072--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.22%. Comparing base (626289a) to head (a71ca43).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18072      +/-   ##
==========================================
+ Coverage   82.87%   83.22%   +0.35%     
==========================================
  Files         404      404              
  Lines       14338    14338              
  Branches     4591     4641      +50     
==========================================
+ Hits        11882    11933      +51     
+ Misses       2296     2243      -53     
- Partials      160      162       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@soumyaraju soumyaraju changed the title test: treeView adding tests Test coverage for TreeView component Nov 14, 2024
@alisonjoseph alisonjoseph requested review from emyarod and removed request for alisonjoseph November 15, 2024 18:46
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@guidari
Copy link
Contributor

guidari commented Nov 19, 2024

Hey @soumyaraju Thanks for opening that!
I noticed the test it 74.48%, is there any reason why those lines weren't tested?

@soumyaraju
Copy link
Contributor Author

Thanks @guidari for looking into this PR, i added few more tests to cover the uncovered lines, thus increased coverage, Please review it. TIA

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnaks @soumyaraju
LGTM 🚀

@soumyaraju
Copy link
Contributor Author

Thanks for the approval, @guidari can you help me merging this PR? TIA

@guidari guidari added this pull request to the merge queue Nov 25, 2024
Merged via the queue into carbon-design-system:main with commit f2ba3fd Nov 25, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase TreeView unit test coverage
3 participants